domuk/Ion-Homepage
Watch
1
0
Fork
You've already forked Ion-Homepage
 0
Code Issues Pull requests Projects Releases 12 Packages Wiki Activity Actions

Release 2.5.1: admin loads again #6

Merged
domuk merged 1 commit from Dev into main 2026-11-07 09:50:06 +00:00
Conversation 0 Commits 1 Files changed 6 +26 -7
domuk commented 2026-11-07 03:25:33 +00:00
Owner

Hotfix for 2.5.0: the admin would not load.

Cause: admin.js declared CARD_KINDS twice at top level — 2.5.0 added one for the service-card integrations, and the Home Assistant cards already had one. A duplicate top-level const is a SyntaxError for the whole module, so the admin page loaded nothing. The home page was unaffected. My pre-release check ran node --check in a mode that did not treat the file as an ES module, so it missed it.

Fix: renamed the new one SERVICE_CARD_KINDS. Also inlined the colours of the Radarr and Pi-hole logos (their <style> blocks are blocked by the CSP).

No migration — schema stays 14. 2.5.1.zip: 8,099,711 bytes, SHA-256 95d7e0b8ac4b13bba6cc2f57600051b0c6505403089175738bec907755987aff.

Verified this time in a real (headless Chromium) browser against a throwaway 2.5.x install with fake data: home page, admin, integrations list, an integration page, its Cards page, the card editor and the admin device popup all load with no JavaScript errors; cards, the Hardware tab (drives + shares) and acks render. Every JS file in the ZIP parses as an ES module.

Hotfix for 2.5.0: the admin would not load. **Cause:** admin.js declared `CARD_KINDS` twice at top level — 2.5.0 added one for the service-card integrations, and the Home Assistant cards already had one. A duplicate top-level `const` is a SyntaxError for the whole module, so the admin page loaded nothing. The home page was unaffected. My pre-release check ran `node --check` in a mode that did not treat the file as an ES module, so it missed it. **Fix:** renamed the new one `SERVICE_CARD_KINDS`. Also inlined the colours of the Radarr and Pi-hole logos (their `<style>` blocks are blocked by the CSP). **No migration** — schema stays 14. 2.5.1.zip: 8,099,711 bytes, SHA-256 `95d7e0b8ac4b13bba6cc2f57600051b0c6505403089175738bec907755987aff`. **Verified this time in a real (headless Chromium) browser** against a throwaway 2.5.x install with fake data: home page, admin, integrations list, an integration page, its Cards page, the card editor and the admin device popup all load with no JavaScript errors; cards, the Hardware tab (drives + shares) and acks render. Every JS file in the ZIP parses as an ES module.
A second top-level CARD_KINDS in admin.js (the service-card kinds clashed
with the HA card kinds) made the whole admin module fail to parse. Renamed
to SERVICE_CARD_KINDS. Radarr and Pi-hole logos had <style> blocks the CSP
blocks; colours inlined.
domuk merged commit 6445322d87 into main 2026-11-07 09:50:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
domuk/Ion-Homepage!6
No description provided.